PointCloudLibrary / PointCloudLibrary/pcl
Access to `points` should be suppressed in PCL code
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Access to points can also be suppressed in a lot of places.
Originally posted by @SergioRAgostinho in https://github.com/PointCloudLibrary/pcl/pull/4190
My observations:
points usage can be removed in following ways:
- replace with functions like:
copyPointCloudinstead ofcopyPoint - replace with functions like
isNormalFinite - replace
points.to use functions ofPointCloud
#4217, #4218, #4219, #4221 tackle third type to a large extent
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the remaining points usages described in this issue and the related work in #4217, #4218, #4219, and #4221. Use the listed replacement patterns to assess each occurrence. Done means the applicable direct accesses have been suppressed without duplicating work covered by those related issues.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100