PointCloudLibrary / PointCloudLibrary/pcl
In preparation for `index_t`, the cast needs to be removed
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
In preparation for index_t, the cast either needs to be removed or it needs to be set explicitly to index_t. I vote for removal unless it's unsupported.
Originally posted by @SergioRAgostinho in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQ0NDE1MTE1NQ==/comments/review_comment
Needs CI run on the PR resolving this issue post #4198 merge
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #4198 and locate the cast discussed in this issue, then check how the surrounding code handles the planned index_t type. Done means removing the cast when supported, or setting it explicitly to index_t otherwise; run CI after the #4198 merge.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100