PointCloudLibrary / PointCloudLibrary/pcl

[android] headers in different include dir for different platforms causes problem

Open
#4,208 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

kind: question module: cmake needs: feedback
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

I am using the conan recipe to build PCL, and i found that the include dir is different for different platform. On LInux, when i compile PCL with the recipe, the header go to : ".conan/data/pcl/ver/usr/channel/package/package_id/include/pcl-ver#/pcl/.h"
when cross compile for android the headers go to :
".conan/data/pcl/ver/usr/channel/package/package_id/include/pcl/
.h"
it is missing one level which is the pcl-ver#, for example for pcl-1.11.0, it is the folder pcl-1.11

This is expected based on https://github.com/PointCloudLibrary/pcl/blob/b0d4f4a375218a725165f194ba586bfcb1917a20/cmake/pcl_utils.cmake#L93
but I wonder if there is a reason for it? Cus this causes a problem for tools like conan, on my computer when using android version, conan still looks for header directory in pcl-1.11, which is missing and thus returns empty string for conan in variable CONAN_INCLUDE_DIRS_PCL

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.