PointCloudLibrary / PointCloudLibrary/pcl

[GPU] CI reports unused functions in Octree sub-module

Open
#4,194 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

effort: medium kind: bug module: gpu needs: feedback
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Describe the bug

Octree submodule of gpu has several functions marked as static in the header. Is static needed for cuda? static should not be needed for headers, and instead the functions should be separated between a header and a cpp file

Expected behavior

No warnings from compilers

To Reproduce

Check the master CI for GPU (example)

Your Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Compiler: Clang 10, nvcc 10
  • PCL Version: HEAD

Pinging @haritha-j

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the GPU Octree sub-module and the master CI log linked in the issue, using the reported Clang 10 and nvcc 10 environment if available. Inspect the header functions marked static and determine whether CUDA requires that arrangement or whether they should be separated into header and source files. Done means the GPU CI reports no unused-function compiler warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, computer-vision
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.