PointCloudLibrary / PointCloudLibrary/pcl

[Visualization / IO] Move methods to save vtkPolyData from visualization to I/O

Open
#4,114 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind: proposal needs: feedback
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

I'm wondering if it is of interest to move this method and leave it up the user to get clouds from the visualizer and save them using I/O.

Simple to remove dependency Visualizer-> I/O.

The other method returns a pointcloud from vtkPolyData can remain, but maybe move it / rename the IO filename?

I can see that visualizer can also add a ply file directly. Should this maybe be moved to I/O as well?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked method in visualization/src/common/io.cpp, then inspect how the visualizer and I/O components currently depend on each other. Determine whether the vtkPolyData-saving method, the conversion method, and direct PLY support belong in I/O, and check the surrounding APIs before making a scoped move. Done means the intended methods are located in the appropriate component without the Visualizer-to-I/O dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.