PointCloudLibrary / PointCloudLibrary/pcl
[apps] Deal with aliases in PointCloud Editor app
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
After #3753, the PointCloud Editor app has mixed references to pcl::shared_ptr and std::shared_ptr due to the existence of the file localTypes.h. I believe the best course of action would be to remove:
and
from the file and deal with the ruckus of every other file using that one in the app. This means using the same strategy of the referenced PR and introducing in-class aliases like e.g.:
class Cloud : public Statistics
{
public:
/// The type for shared pointer pointing to a selection buffer
using SelectionPtr = pcl::shared_ptr<Selection>;
[...]
};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/localTypes.h, inspect the aliases at the referenced lines, and search the PointCloud Editor app for their users. Replace the shared-pointer aliases using the in-class approach described in the issue, then build the app and confirm the mixed alias references are gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100