PointCloudLibrary / PointCloudLibrary/pcl

[Question] Are the docs for ICP tutorial up to date?

Open
#3,969 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

effort: low good first issue kind: question module: docs needs: testing
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

[Question]
Hi, I'm trying to do reconstruction with PCL 1.8.1.
I've setup a project to do ICP and it seems to be working however I'm not sure what to expect regarding its output and accuracy.

So I tried the tutorial here :
http://pointclouds.org/documentation/tutorials/pairwise_incremental_registration.php

But the result aligned cloud seems off, as shown in the image below

registration

As the white arrow points out, the stairs are not aligned properly. You can see the double image.

I expected the alignment to be better than this, so is there something I'm missing?

I didn't change any code from the tutorial except :

reg.setPointRepresentation(boost::make_shared<const MyPointRepresentation>(point_representation));

PCL 1.8.1 doesn't have memory.h for make_shared so I just changed to use boost's.

I don't think this makes a difference but I'm not sure.

Please advise if this is indeed the expected behavior or there are things I can do to make it better.

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the pairwise incremental registration tutorial linked in the issue and compare its documented output with the reported PCL 1.8.1 result. Check the stated change from memory.h to boost::make_shared and determine whether the tutorial needs clarification about expected alignment or accuracy; done means the documentation or expected behavior is clearly explained.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision, documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.