PointCloudLibrary / PointCloudLibrary/pcl

Make const usage better in function signatures

Open
#3,968 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

changelog: enhancement effort: low good first issue kind: todo
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Context

clang-tidy has been used successfully before to make wide changes. We can use it to improve the API in the whole repo. We need discussion on the potential fix and just applying the other fixes after setting up clang-tidy.

Describe the solution you'd like

Apply the following fixes:

Another potential fix:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CONTRIBUTING.md and the issue's clang-tidy checks: const-return-type, make-member-function-const, non-const-parameter, and possibly convert-member-functions-to-static. First establish the clang-tidy setup and discuss the potential fixes; done means the agreed checks have been applied across the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.