PointCloudLibrary / PointCloudLibrary/pcl
Use `PCL_DEPRECATED` uniformly to provide deprecation
Open
Nobody has claimed this yet.
needs: feedback
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Executing git grep -n deprec and trying my best at recognizing the results needing homogeneity leads to these questions:
- Does pcl/outofcore/octree_disk_container.h need deprecation somewhere around here? https://github.com/PointCloudLibrary/pcl/blob/86ba2c118ac343d7ea8f8a21cf97364ff2d700a5/outofcore/include/pcl/outofcore/octree_disk_container.h#L288-L302
- Are OpenNurbs'
ON_DEPRECATEDalsoPCL_DEPRECATED? - Does test_outofcore also need a touch up? https://github.com/PointCloudLibrary/pcl/blob/86ba2c118ac343d7ea8f8a21cf97364ff2d700a5/test/outofcore/test_outofcore.cpp#L315
The existing easy ones are in #3925
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the deprecation results from git grep -n deprec and inspect the referenced sections in pcl/outofcore/octree_disk_container.h, surface/3rdparty/opennurbs/opennurbs_defines.h, and test/outofcore/test_outofcore.cpp. Compare these cases with the existing easy changes in #3925, then determine which declarations or tests should use PCL_DEPRECATED and verify the affected tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- developer-experience
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100