PointCloudLibrary / PointCloudLibrary/pcl
Linking downstream projects on MacOS Catalina might be broken
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
I haven't addressed the downstream part yet i.e.: it the project is compiled with OMP and requires linking flags, the assumption is that if the linking flags are not propagated to a downstream project it will have linking issues.
Edit: I saw the new issue now. You can merge this and I can try to address it later. At least the user will be able to build PCL. He can later report if he later had linking issues.
Originally posted by @SergioRAgostinho in https://github.com/PointCloudLibrary/pcl/pull/3721#issuecomment-613855914
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request 3721 and the linked discussion about downstream projects on macOS Catalina. Reproduce a build where PCL is compiled with OMP, then check whether a downstream project receives the required linking flags. Done means PCL builds and the downstream linking behavior is confirmed or corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100