PointCloudLibrary / PointCloudLibrary/pcl
[filters] Create a SamplingFilter base class
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Having a seed is something which is common to all sampling classes. I have a rough feeling it would be good to create a SamplingFilter base class. Something for another PR.
Originally posted by @SergioRAgostinho in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzcwOTgwNjYy/pull_request_reviews/more_threads
This class should use modern C++11/14 <random> header along with modern PRNG and entropy sources provided by stdlib
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the existing sampling filter classes and how each currently handles its seed. Define the shared base around the common behavior described in the issue, using the C++11/14 facilities and standard-library PRNG and entropy sources. Done means the sampling classes share the new base without losing their existing behavior, with coverage for the changed seed handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100