PointCloudLibrary / PointCloudLibrary/pcl

Check if read succedded before reading again/allocating memory

Open
#3,606 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted kind: bug needs: pr merge
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Your Environment

  • PCL Version: HEAD

Context

Bad parsing is inevitable, specially if operations are performed on read data without validation

Expected Behavior

Graceful error detection

Current Behavior

Files: 273 instances. One sample provided:

Possible Solution

Sanity checks on input stream after reading before allocating memory

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with features/src/narf.cpp:576, the sample location named in the issue, and review the 273 instances reported by the linked Codacy results. Determine which reads require validation before subsequent operations or memory allocation, then verify that affected inputs produce graceful errors rather than continuing with bad data.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.