PointCloudLibrary / PointCloudLibrary/pcl
Use CMake instead of custom macro logic for compiler dependence
Open
Nobody has claimed this yet.
kind: todo
module: cmake
skill: cmake
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Your Environment
- Operating System and version: All
- Compiler: All
- PCL Version: HEAD
Context
PCL has a lot of macros defined manually for backward compatibility. I discovered write_compiler_detection_header command in cmake_compile_features from this module. It seems to do most of what we want, out of the box.
Might be nice to use
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the CMake cmake_compile_features documentation and the WriteCompilerDetectionHeader module linked in the issue. Then locate PCL’s manually defined compiler-compatibility macros and determine which are covered by CMake’s detection command. Done means the relevant custom macro logic is replaced without losing backward-compatibility behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100