PointCloudLibrary / PointCloudLibrary/pcl

memset for Eigen::Matrix in integral_image2D.cpp

Open
#3,368 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

effort: medium kind: todo module: features skill: meta-programming
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Lines 159, 190 in file features/include/pcl/features/impl/integral_image2D.hpp:

https://github.com/PointCloudLibrary/pcl/blob/8ab5ae4cf97277e92ebf66d591d8b14aefae9a1a/features/include/pcl/features/impl/integral_image2D.hpp#L159

https://github.com/PointCloudLibrary/pcl/blob/8ab5ae4cf97277e92ebf66d591d8b14aefae9a1a/features/include/pcl/features/impl/integral_image2D.hpp#L190

memset is being called upon ElementType and SecondOrderType which are template parameter. As such I don't see a way out of the warning, unless we are guaranteed that types have data field if it has no trivial copy-assignment

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting features/include/pcl/features/impl/integral_image2D.hpp at lines 159 and 190, focusing on the memset calls involving the ElementType and SecondOrderType template parameters. Check the relevant compiler warning and the surrounding integral-image code. Done means the warning is addressed without assuming unsupported template properties and the existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.