PointCloudLibrary / PointCloudLibrary/pcl
PCLPointCloud2 concatenation operation needs to consider the field size
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Currenty, PCLPointCloud2::concatenate assumed same name implies same datatype. WIth the PR #3312 this will no longer be true. This issue was found during refactoring of #3320
Context
Fields will no longer be restricted to float_32 so concatenating it with a field of datatype float_64 will result in a corrupted output.
Expected Behavior
During concatenation, a check of field datatype should be performed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the PCLPointCloud2::concatenate entry point and review the field handling affected by PR #3312. Reproduce concatenation with same-named float_32 and float_64 fields, then verify that the datatype is checked and the output is no longer corrupted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100