PointCloudLibrary / PointCloudLibrary/pcl
[Clang-Tidy] Inefficient string concatenation
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Just a ticket as notification, so I can link information to clang-tidy ticket:
Current issues I won't fix, because they are not this much important and imho decrease readability:
string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead.
Affected lines:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the three affected locations: apps/src/face_detection/filesystem_face_detection.cpp:231 and recognition/src/face_detection/face_detector_data_provider.cpp:83 and :91. Start by checking the referenced clang-tidy warning and whether these concatenations should remain for readability; done would require a decided resolution for all listed lines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision, tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100