PointCloudLibrary / PointCloudLibrary/pcl
Inconsistent handling of default seed in NormalGenerator & UniformGenerator
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
As already discussed here default seed in random.h is not handled consistently.
One constructor of NormalGenerator has as default seed -1 during the other one (via Parameters) has 1 as default seed.
Furthermore you get currently following warning:
common/include/pcl/common/impl/random.hpp:49:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(parameters_.seed != -1)
So we should discuss how to adjust code there.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the NormalGenerator constructors and Parameters in common/include/pcl/common/random.h, then trace the seed check in common/include/pcl/common/impl/random.hpp. Compare the two default-seed paths and reproduce the signed/unsigned warning. Done means the default seed behavior is consistent and the warning is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100