PointCloudLibrary / PointCloudLibrary/pcl
Revise need of pcl_apps library target
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
I just noticed this
https://github.com/PointCloudLibrary/pcl/blob/356ea4f63a147051bf1eae0535e093c312ad5383/apps/CMakeLists.txt#L215-L221
I'm inclined to replace it with regular executable targets. Currently it's compiling source files from apparently two different applications into a PCL Library "target" called pcl_apps. 😕
Originally posted by @SergioRAgostinho in https://github.com/PointCloudLibrary/pcl/pull/2691#issuecomment-469875858
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps/CMakeLists.txt around lines 215-221 and inspect how the sources from the two applications are assigned to the pcl_apps target. Check the surrounding application target definitions and build configuration. Done means the applications use regular executable targets rather than the combined pcl_apps library target and the relevant configuration still builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100