PointCloudLibrary / PointCloudLibrary/pcl
Replace boost::mt19937 with std::mt19937
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
boost::mt19937 is sometimes used in header files as member. How do we migrate to std::mt19937 there? A typedef doesn't work, because e.g. boost::variate_generator doesn't exists in final C++11 spec (was only in tr1).
So there are two options:
- Hardcut for this members. Everyone, who inherits from this classes, needs ti adjust their code from PCL 1.9.1 to 1.10.0 in case they are using this member.
- typedef + #ifdef (don't know if we want many new #ifdefs)
- typedef and increase/define minimum required boost version, in case Boost implemented C++11 spec
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the header-file members that use boost::mt19937 and checking their use of boost::variate_generator against the C++11 standard. Define the supported migration path for PCL 1.9.1 users, including whether inherited members require changes and whether the minimum Boost version must increase.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100