PointCloudLibrary / PointCloudLibrary/pcl

Revise compiler flags being used.

Open
#2,669 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module: cmake status: stale
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

The compiler flags currently being used by the library are a little messy and chaotic with some inconsistencies here and there. If possible, I would like to clean it up. Please chime in.

General purpose

Gcc/Clang/AppleClang:

  • Wall
  • Wextra

CL:

  • Need input

Intel:

  • Need input

Pathscale(?):

  • need input

SSE

These are automatically set during the configuration stage. Currently we look for

Gcc/Clang/AppleClang:

  • march=native
  • mfpmath=sse
  • msse4.2
  • msse4.1
  • msse3
  • msse2
  • msse
  • ffloat-store

CL:

  • /arch:SSE2
  • /arch:SSE

Intel:

  • need input

Pathscale(?):

  • need input

Edit: I like to start all my projects with -Wall -Wextra by default and that is usually what I go for.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the configuration-stage compiler flag definitions; the issue names no file, test, or entry point. Compare the General purpose and SSE flag lists for GCC, Clang, AppleClang, CL, Intel, and PathScale. Done means an agreed, consistent flag policy with the missing compiler inputs resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.