PointCloudLibrary / PointCloudLibrary/pcl
Revise color integration in kinfu
Open
@haritha-j is already working on this.
Since Jun 7, 2020.
module: gpu
status: stale
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
What should happens with this variable in general? It is initialized with false and can only be set to true with toggleColorIntegration. But before any usage of this variable, value will be reverted to false, so toggleColorIntegration has no effect.
So there exists two options: Remove toggleColorIntegration or remove integrate_colors_=false; line in execute function. What do you prefer?
_Originally posted by @SunBlack in https://github.com/PointCloudLibrary/pcl/pull/2648#discussion_r236639379
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.