PointCloudLibrary / PointCloudLibrary/pcl
Update CMake scripts in tutorials (remove superfluous include_directories et al. calls)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
I was thinking about the CMakeLists in tutorials, do they need to be updated as well? My conclusion was no, not yet. It should still be possible to use PCL in downstream projects with old CMake. But once we switch to C++14 we should consider bumping version there and requesting CXX_14 explicitly.
Originally posted by @taketwo in https://github.com/PointCloudLibrary/pcl/pull/2605#issuecomment-437301261
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the tutorial CMakeLists files and the discussion in pull request #2605 referenced in the issue. Confirm whether the cleanup is intended now or only after the C++14 transition, then define completion as consistent tutorial CMake scripts that preserve the stated downstream compatibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100