PointCloudLibrary / PointCloudLibrary/pcl

Looks like gicp6d should use PointXYZRGB instead of PointXYZRGBA

Open
#2,587 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind: proposal module: registration needs: pr merge
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Your Environment

  • Operating System and version: Ubuntu 18.04
  • Compiler: GCC 7
  • PCL Version: Latest

Context

I was attempting to use gicp6d for my application and then I realized it only supports point type PointXYZRGBA as input and I am unable to pass in PointXYZRGB point type. To my understanding gicp6d does not consider alpha when doing the alignment and I further look into the code https://github.com/PointCloudLibrary/pcl/blob/cc7fe363c6463a0abc617b1e17e94ab4bd4169ef/registration/include/pcl/registration/gicp6d.h and https://github.com/PointCloudLibrary/pcl/blob/cc7fe363c6463a0abc617b1e17e94ab4bd4169ef/registration/src/gicp6d.cpp there is not a single place that the alpha channel is being used. Before I submit a PR that simply changes PointXYZRGBA to PointXYZRGB in gicp6d.h, @taketwo and @SergioRAgostinho is there anything that I misunderstood that makes PointXYZRGBA required?

EDIT: I made the changes locally and it seems to be working just fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing registration/include/pcl/registration/gicp6d.h with registration/src/gicp6d.cpp, focusing on the PointXYZRGBA input type and whether alpha is referenced. Confirm that PointXYZRGB can be used without affecting alignment, then verify the relevant gicp6d behavior and ensure the requested point type is supported consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.