PointCloudLibrary / PointCloudLibrary/pcl
inconsistent data member naming convention in pcl::PointCloud
Open
Nobody has claimed this yet.
module: common
needs: feedback
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Your Environment
- PCL Version: the master branch
Context
Some data members are ended with _ and some are not.
Expected Behavior
Either all end with _ or none.
Current Behavior
The naming convention is not consistent.
Code to Reproduce
See the code above.
Possible Solution
Rename the data members consistently.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read common/include/pcl/point_cloud.h at the referenced lines around the data members and inspect the surrounding naming conventions. Determine the consistent convention and identify the affected members and their usages; done means the relevant pcl::PointCloud data members follow one convention without breaking their existing interfaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100