PointCloudLibrary / PointCloudLibrary/pcl
Suspicious behaviour in 'connectPoint' in 'gp3'
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
A follow-up on the recent discovery from @puzzlepaint, just to keep track on things.
I think there may also be a bug where the connectPoint function adds a triangle in a place which is designated as a gap by the triangulation function, and then the ffn_/sfn_ are not updated correctly there, but I'm not sure and I don't have a fix for that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the referenced pull request #1879, then locate connectPoint in the gp3 triangulation code. Investigate whether it adds a triangle in a designated gap and leaves ffn_/sfn_ inconsistent. Done means the behavior is confirmed or ruled out and, if confirmed, corrected with suitable verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100