PointCloudLibrary / PointCloudLibrary/pcl

Replace pcl::visualization::createPlane and pcl::visualization::PCLVisualizer::addPlane overloads by default arguments

Open
#1,653 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue kind: todo module: visualization
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

The code is pretty similar and can be probably reduced by simply making a change to its signature with default initializers.

bool addPlane (const pcl::ModelCoefficients &coefficients, 
               double x = 0,
               double y = 0,
               double z = 0,
               const std::string &id = "plane",
               int viewport = 0);

and

PCL_EXPORTS vtkSmartPointer<vtkDataSet> 
createPlane (const pcl::ModelCoefficients &coefficients, double x = 0, double y = 0, double z = 0);

pcl::visualization::PCLVisualizer::addPlane method:

pcl::visualization::createPlane method:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the two addPlane implementations in visualization/src/pcl_visualizer.cpp and the two createPlane implementations in visualization/src/common/shapes.cpp. Check their corresponding declarations and callers, then consolidate the overloads using the proposed default arguments while preserving existing behavior and calls.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.