PointCloudLibrary / PointCloudLibrary/pcl
Detect Ensenso version at PCL configuration
Open
@VictorLamoine is already working on this.
Since Oct 22, 2015.
good first issue
kind: todo
module: cmake
skill: cmake
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
There should be a minimum Ensenso version in PCL config to make sure users don't have an old EnsensoSDK installed.
On Linux platforms there is a CMake and pkgconfig files installed (SDK 1.3.146 and above) but not on Windows.
$ pkg-config --modversion ensenso-nxlib
1.3.167
See https://github.com/PointCloudLibrary/pcl/issues/1200#issuecomment-150162667 for a multi-platform method; but there's no such macro in the EnsensoSDK:
$ grep -i "1.3.167" /opt/ensenso/ -r
/opt/ensenso/pkgconfig/ensenso-nxlib.pc:Version: 1.3.167
/opt/ensenso/pkgconfig/ensenso-nxlibremote.pc:Version: 1.3.167
/opt/ensenso/manual/html/changelog.htm:<td style="vertical-align:top; width:333px; padding:0px;"><p>1.3.167</p>
/opt/ensenso/manual/html/changelog.htm:<td style="vertical-align:top; width:120px; padding:0px;"><p>1.3.167</p>
/opt/ensenso/manual/html/zoom_index.js: "1.3.167 65 8 64",
/opt/ensenso/manual/html/zoom_pageinfo.js:["changelog.htm","About > Changelog","About Changelog Navigation: About Changelog EnsensoSDK Revision 1.3.167 Last edited 21.08.2015 Changelog Version Changes 1.3.167 Fix: NxView: Adde...",""],
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.