PointCloudLibrary / PointCloudLibrary/pcl

pcl::PPFEstimation class uses PFH features instead of PPF features

Open
#1,131 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module: features needs: feedback
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

in the impl/ppf.hpp in the method to compute the pair features, PFH features are calculated instead of PPF. At line 77, the actual pcl::computePPFPairFeature method is commented and it is using pcl::computePairFeatures from pfh.hpp which calculate PFH features.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading impl/ppf.hpp around line 77, then compare the referenced pair-feature methods in pfh.hpp. Confirm which method PPFEstimation should use and check the existing PPF-related tests or examples. Done means the class computes PPF features rather than PFH features without breaking its current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.