PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warning when calculated hit damage exceeds hit damage cap
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
Hits above 2.147... billion deal no damage in-game. (personally tested in game this week, wiki will be updated soon)
Describe the solution you'd like
A warning in pob to let people know. Nothing more heavy-handed is warranted imo.
Describe alternatives you've considered
none
Additional context
TLDR
If you want the maximum performance inside poe, you want your max hit with all boxes checked to be below 2.1b. invest into attack speed and qol and quant with the rest
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the hit-damage calculation and any existing warning or validation UI. Confirm how the 2.147-billion damage cap is represented, then verify that a warning appears when calculated hit damage exceeds it and remains absent below the cap.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100