PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Do not suggest Arcane Surge Support for skills that only spend life

Open
#9,717 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

With no sources of obtaining arcane surge other than support, every life-spending build (and they are quite popular nowadays with lifestacking) has Arcane Surge Support showing up in the link suggestions as one of the best supports to use.

Obviously, you can only gain arcane surge when spending mana (unless you have other sources available, like for example arcane surge from zealotry watcher's eye or Hierophant ascendancy), but without them active in your build, arcane surge should never appear as a damage increase for life-spending builds.

In short, it appears POB is incorrectly assuming that every skill can gain Arcane Surge buff from the support.

Describe the solution you'd like

If no other sources of gaining arcane surge are available, Arcane Surge support should never appear as suggested damage booster for your life-spending skill.

Describe alternatives you've considered

No response

Additional context
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Path of Building with a life-spending skill and no non-support Arcane Surge source, then inspect the link-suggestion calculation for Arcane Surge Support. Done means the support is not suggested in that case while builds with another available Arcane Surge source retain the suggestion.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.