PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Repeating should not display 'burst damage' for spells
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 5.4k
- Forks
- 2.4k
- Merge moyen
- 1 j 12 h
- PR mergées (30 j)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
Spells that repeat should not display 'burst damage'. The repeat mechanic repeats animations: if a 1-second cast outputs 100 damage, making it repeat will require a total of 2 seconds to output 200 damage. Repeating doesn't deliver damage any faster or in a burst - its main purpose is performing multiple animations for one cost and one cooldown.
Most sources of repeating are accompanied by cast speed modifiers, but those are handled through cast rate normally.
How does Path of Building behave?
When a spell repeats, the side menu will display an 'Average Burst Damage' that multiplies the average hit by the number of repeats (regardless of cast rate).
I may be mistaken about the intention of this feature, but it seems to me that it's only appropriate for effects that reoccur due to Unleash.
(Making attack skills repeat with e.g. Multistrike, Echoing Shrine, Fatal Flourish, etc. does not display burst damage.)
How to reproduce the issue
- Add Frostbolt
- Add Spell Echo Support
- Observe that 'Average Burst Damage' appears in the side menu, and in Skill type-specific Stats in the Calcs section. It is twice the average hit (at any level of Spell Echo Support).
PoB for PoE1 build code
eNq9W1tz4rgSfp79FS7eJ4CBXLaS3SIhmVCVTDiQmTnnaUrYArQjW6wsJ2F__bYkX8HGMnadPMwY09_XrZZa6m6b6z8_PGq9YR4Q5t90-me9joV9h7nEX990vr0-fL7s_PnHb9czJDYvq9uQUPnNH799ulbXFsVvmAKuY70R_P7MXHzTmT7PXuavHQsFDvbdO4qC4Cvy4IuvzMcdSyC-xuJ7rHLwE1RukS82mPnP6C_GvzA3lk3uEz9339kgjhyB-ZPUPw4F06oFD-FbDxF_wZxfWHzhLNwq85bId4lI8KlRCwfM6MCIPl3PKNphvhBIWAH8c9MZg2PQGj8SAeNDNATxfs_unw379qjTPYq5DXkgJsiDywRr94b22WU5dLHF2E2lz3qjQfpXBppxfL9aYUeQN3zHibjbIN9JdZYqqyv7HFJBtpRgnvrirBTxeEDe7_XKhF-ZQHQyW2QcdXVxNuj1KoaucSydnFINP4jY3FLw7glaJHa69onAJ4JnjATMbzC-LLR0iHchpRCaRrJzHGD-hgTJm1XOzbwl8U_y3jPy0R0L0jkajI6JzjCHTUPkEL0KwAI7DPaZvJKzK4PYyWgs5ilV_URW2Fyy1qgiQF1rThvH_cJUrjbxaQbNYcM0k1ywkBpKCp5ZtmVSE_xhIDX1hYHUHP-dFeyPRuVa35iMw-pRqN3g_nGWLvLLM9u-6tsXvYuL8kNlttkFxEH0GX0QL_RgY35Fv3Cq7_zIqlpvhA97Shl0cFEGfSAc10fdMeqegNogFpTCLo_FjIET4Ex2fpeyU98xC8RvPlfba-YoPz8KmEN4yKRhSbEhIlURBZnJKatVrbEf6duZDecJY2fzBTKqORLYbE9OE4rjbpWyRm6VggVuHRkCajhJAkucdHZ1DFTTTfc-5uvdYkMwdetJx4bdoa3BzifdnEUbuTuvrtaKyUJruuQH4q7Z-VDXpjcUZHfY_vlxd2lxs4WJIakEgIv3st1eebrO_pLJOq0HG3OPhdxwwrWw0QDi00FXKnPsho7ZaZTUHLcUKi3TYSQosJPSWtCxEMj5NWHu2thpSkktRN6-Rbjdwh4iV4MpgTz4ILsmmbTk87mB9AssZaOIlmekuYJU2lhBcuqba9mDmI9Fntw1BpOKG6tIJvQZNgsPDgFVYz-zdKfpl04OFFRG1ZESNKzSZuwdLN_IFkhQTxoynDSrKTWFY_-fnTF_TtxIwb3vhlyGgrGOfUSRmlfiwUYaBBMkkBVgxJ3NE8zyA6J0CUF_0-lYbpQnf0ecIF_0VVNn76atbqZ4wEn-667qVcmrO0SdQKmc-ttQmshVo-v-4eH-7nX6_b5j-aor5JHA-bkMVyvZV4qs1BA_9JaYK01aNPhFKP2pb0eSC6x2UYu4sAnJrxcwPAcWucMoRdsAw_0VogFsKEG4DLT0Tec7we9KfIIFIjQoYIMEN24qHedSPKn0IRMctw4ncgaPE91_YC7ASYn8IZVqwRiYo22Rp7ac8CJf6QbYcSp9ENyhQKi84pBFdquqSKRM0VCm3hbRSudGUiWT_brbYhkAgZFTBEgHcGqTFXE0qnDW4wOowjeOA8Hm7Ao4VPurCq-FDsG6hVWFjqQKvKraZ5Ve1VIF6ws7aFeF1kKH4CQLrSJIBJkvG76HTPcUjwmVh0jlzH5lvlrsEDcJ5JDwGTYZfUBVEr6IDeax7CETxAQny1BUh3NGssBXqiaucJOUKRiLqvuOQ5VMgV9ztVDFbpSVLdzUKimUzCE0zkOOg7VU4RREGXqF-7VUgRPiIqVi_JFYQZCozXX8xohrslPsizcmVMl8C3bJdL05zX7-XsD4QFHwqzJeIikjuH76lEV_g0KPiF0zEhlxzRhk4DVjeCW-I0JeuGvM99ORQ_i8OAdJksij4FjqVHySgZ7MoPPkk-EqjS_Z_yd4hcE0swMgEW7G9cAgo4N0Qz0Aasi1EKE_AffWpTr0khrhsQ2pNpc-eY84TW8qUcfYZL_Uos2JIC94LE5AazAlte0jRlQ-ZmS0GeF-E92crCDiscPCLfLdmO2lPO2v4z0mAiBVBd1EtgGDRlZCOuHtMjzX3bhCvP7KIEeS1PJu_OH6jvkrsraQftyuPiywkNWgsiK5o-zQN1VN7OANoy7mSfl40evFBSSWRujSp1sOGOXEM0_vj2AGvQNQth4sBiWFrZc88VdueoRqnL3DyoUDwzvKYNvDfk5xvst4VPnoULt8ho45dheq7mOhL6CcXtUcQt56RRXMsQfFqHu7G1O6qzUg2birHszl1Xne_7KBVQ0bHKiaxcFoAki6cbVQslNYAcjMjWx7TyARrlqA5_2ry6ucnmwCXKKm1x_mbcslvcWgYbLSt0mD3cTAZFoXG0hf9bKotRKk36qn9ACWTFI19iIfxFGnHna1OfIr1t8wr1O-K1Vnu8i0Z41c6DDubKp9mCwjR--WW5gujugrWWOuwvsouFfsx2o795CZTr3J4AKyJvRlpVI5GGKSjxrpyjTt9WnVTQ4KfeioT_LylWMs24BWsGHvsh00IXDKc5XAxAfYP4x5_5MdV3X1pN_AG-hP_1X3dQt0IXjcAVWdpsAKIPH7gr3gdjeZLWI6F68QbJNw_z8hktWKppD6oX7SCNnSAv3jpyf9zZiKSFjSpSc1fPWE18jJ3041RMb6jHvJGwmd6DSNGqVCN3Gzlj7Iaj__FpI-8yNE7rBVNy2KllKRfhdwnPIrcuzLZ-1JQgClDQ1dPPWjjj_YR-gBUiUGiZpP12BdRPSFsiWidkz3ppvRU1lacRaIW0aFXg1ypUc3l-rmniHRy5R2r5Nj7sff_52Zn-h6qtpjyr0da409-fkZC-QigbpTAR7sSjd21RDgKmORI0NNO1t-mbe3W2OU0TJRJfe9s2HZwaqblr77fxxtsnDVW4sOCorHe2B5FNLaXTpS40WmAlXHkbycehJp4Q_53wxxaahe7irglDHRwpbX8boOA6zfhvqB0Zb56rZabeXxrp89aI5opZfSRCFAGUgK7R_wnrycLb_Nn2RA6G3pFieTbCKu1Vh9a_GOttZ4uQsCRC39jq1lt0U0aIto2BbRqC2i81OI9jj6LXCcMFd2W5NutzXpdluTbrc16XbjSVdduFqqYbt8S7MQk5hnTNSRn0NaVWvRKYBdF3DSAmgeGnYrK7qNxdzGOm5jCTdYvY-YegBpMCvFDHZjhkFjhmFjhlFjhvNaYe7uLF1mN5mQIzR2OzSDdmiG7dCM2qE5r72DN5mkYga7McOgMcOwMcOoMcN53cOxWbwUENhNCQZNCYZNCUZNCWrNApQljSahAG83xA8a4ocN8aOG-PNTa5hT0-A6ccvRquaOpxCnlJw1IGMvpFjUPrVPcNhph05bVWm_doFSH2HXRgxqI1or_doosdso9UctcAxb4Ihf0O1G_SfVBFO9rbhZHTdvVbcvegoqP1hCdrLTH3nbl7KjGgjMd9FrbFK7-h12ZFbm5-LRHZ-5sgs2urwcDGRTWza8EN-N84Jp3wuGpNuWGyG2we_d7vv7-9kWiQ1b4Q9C8ZnDvO4WYGDwZ9UE_Cyt7I7h73Y9Vn-6_xczXWs_BJEn5TNsTsCoyCtyoMol0hPyQjUCLRAQxEfRG1-Uwti2WzA5aYgvZAvdfZMPp14Zo0GmdXjd3f-p_b8JoFrU
Screenshots
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Reproduisez le problème avec Frostbolt et Spell Echo Support, puis suivez le Average Burst Damage affiché dans le menu latéral ainsi que les Stats spécifiques au type de Skill dans la section Calcs. Confirmez le comportement existant pour les sorts répétés et comparez-le au cas Unleash indiqué. Le travail est terminé lorsque les sorts répétés n'affichent plus de dégâts burst, tandis que les calculs de dégâts concernés restent corrects.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- desktop, game-dev
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 55/100