PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Ways to exclude mods from "trade for these items" generated queries
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
The trade site's limit on the # of things you can search by can sometimes mess up the "search by full DPS" results from PoB, because sometimes there are relevant mods that don't make the cut. Because there are so many possible damage scaling stats, it's very easy to hit the trade site limit while still excluding important mods
Describe the solution you'd like
I would like some way of excluding mods in advance of generating the query. For example: allowing us to pick a base type to exclude implicits from being in the query that realistically will never be there. Or just the ability to straight up exclude certain mods, like "culling strike" which is weighed highly but is not a realistic stat to have on a weapon in certain cases
Describe alternatives you've considered
The common solution is to go manually edit the search result and remove/add weights as you see fit. But the problem with this is I don't know how to calculate the weights of stats i'm adding manually, and i might not know all of the possible stats out there that might scale my damage the best
Additional context
I searched for "exclude" "trade for these items" but didn't find any existing enhancements. sorry if i missed one.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Das Issue nennt keine Dateien, Tests oder Einstiegspunkte. Beginne damit, den Code zu finden, der Abfragen „trade for these items“ erzeugt, und überprüfe, wie Mod-Gewichtungen und implizite Modifikatoren ausgewählt werden. Kläre, ob Ausschlüsse von Basistypen, Ausschlüsse expliziter Mods oder beides erforderlich sind, und definiere „fertig“ als das Erzeugen einer Abfrage, die die ausgewählten Ausschlüsse ohne manuelle Bearbeitung berücksichtigt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- api
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100