PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Ways to exclude mods from "trade for these items" generated queries

Open
#9,681 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

The trade site's limit on the # of things you can search by can sometimes mess up the "search by full DPS" results from PoB, because sometimes there are relevant mods that don't make the cut. Because there are so many possible damage scaling stats, it's very easy to hit the trade site limit while still excluding important mods

Describe the solution you'd like

I would like some way of excluding mods in advance of generating the query. For example: allowing us to pick a base type to exclude implicits from being in the query that realistically will never be there. Or just the ability to straight up exclude certain mods, like "culling strike" which is weighed highly but is not a realistic stat to have on a weapon in certain cases

Describe alternatives you've considered

The common solution is to go manually edit the search result and remove/add weights as you see fit. But the problem with this is I don't know how to calculate the weights of stats i'm adding manually, and i might not know all of the possible stats out there that might scale my damage the best

Additional context

I searched for "exclude" "trade for these items" but didn't find any existing enhancements. sorry if i missed one.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the code that generates “trade for these items” queries and review how mod weights and implicit modifiers are selected. Clarify whether base-type exclusions, explicit mod exclusions, or both are required, then define done as generating a query that respects the chosen exclusions without manual editing.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.