PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Primal Owl incorrectly applying to max bonus to first hit and all Reoccurrences

Offen
#9,605 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: calculation
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-Game when waiting for Max Unleash Seals and using The Primal Owl (Oshabi), I believe it should be calculated with 0 bonus for first hit and an ascending bonus for each Reoccurrence after.

So if you have 6 seals with a level 20 gem and Primal Owl, then Unleash would provide

1 + .64*(1+1.05+1.10+1.15+1.20+1.25+1.30) = 5.512

This can be represented by the formula where:
u = Damage multiplier with Unleash but no Primal Owl
p = Damage multiplier with Unleash and Primal Owl
s = Number of seals when cast
g = Unleash Support's reoccurrence multiplier (eg 0.64 at level 20)
u = 1 + sg
p = 1 + sg(1 + 0.05(s + 1)/2)

For example:
s = 6
g = 0.64
u = 1 + 6*0.64 = 4.84
p = 1 + 6*0.64*(1 + 0.05(6 + 1)/2) = 5.512

What is the value from the calculation in Path of Building?

In PoB, when using The Primal Owl with Unleash Support, PoB calculates the highest Primal Owl bonus (ie the bonus for the final reoccurrence in that cast) and applies it to the entire unleash burst, including the first hit that is not an Unleash reoccurrence.

It appears to use the following formula where:

p = Damage multiplier with Unleash and Primal Owl
s = Number of seals when cast
g = Unleash Support's reoccurrence multiplier (eg 0.64 at level 20)
p = (1 + sg) * (1 + 0.05 * s)

For example:
s = 6
g = 0.64
p = (1 + 6*0.64) * (1 + 0.05 * 6) = 6.292

How to reproduce the issue
  1. Select Arc as the main skill
  2. Add Unleash Support to Arc
  3. Tick on Do you wait for Max Unleash Seals?
  4. Select Oshabi Bloodline
  5. Allocate The Primal Owl
  6. See incorrect More Multiplier and damage
PoB for PoE1 build code
https://pobb.in/06T0iKY7XS84
Screenshots

Without The Primal Owl:
Image

With The Primal Owl:
Image

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, das Arc- und Unleash-Support-Setup mit sechs Siegeln, Oshabi Bloodline und The Primal Owl unter Verwendung des verlinkten PoB-Builds zu reproduzieren. Verfolge die Berechnung, die den More Multiplier erzeugt, und vergleiche sie mit der erwarteten Formel des Issues, bei der der erste Treffer keinen Primal Owl-Bonus hat und jede erneute Auslösung ihn erhöht. Fertig ist es, wenn der angezeigte Schaden für diesen Fall mit dem gemeldeten Multiplikator von 5.512 übereinstimmt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
game-dev
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.