PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Primal Owl incorrectly applying to max bonus to first hit and all Reoccurrences

Open
#9,605 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-Game when waiting for Max Unleash Seals and using The Primal Owl (Oshabi), I believe it should be calculated with 0 bonus for first hit and an ascending bonus for each Reoccurrence after.

So if you have 6 seals with a level 20 gem and Primal Owl, then Unleash would provide

1 + .64*(1+1.05+1.10+1.15+1.20+1.25+1.30) = 5.512

This can be represented by the formula where:
u = Damage multiplier with Unleash but no Primal Owl
p = Damage multiplier with Unleash and Primal Owl
s = Number of seals when cast
g = Unleash Support's reoccurrence multiplier (eg 0.64 at level 20)
u = 1 + sg
p = 1 + sg(1 + 0.05(s + 1)/2)

For example:
s = 6
g = 0.64
u = 1 + 6*0.64 = 4.84
p = 1 + 6*0.64*(1 + 0.05(6 + 1)/2) = 5.512

What is the value from the calculation in Path of Building?

In PoB, when using The Primal Owl with Unleash Support, PoB calculates the highest Primal Owl bonus (ie the bonus for the final reoccurrence in that cast) and applies it to the entire unleash burst, including the first hit that is not an Unleash reoccurrence.

It appears to use the following formula where:

p = Damage multiplier with Unleash and Primal Owl
s = Number of seals when cast
g = Unleash Support's reoccurrence multiplier (eg 0.64 at level 20)
p = (1 + sg) * (1 + 0.05 * s)

For example:
s = 6
g = 0.64
p = (1 + 6*0.64) * (1 + 0.05 * 6) = 6.292

How to reproduce the issue
  1. Select Arc as the main skill
  2. Add Unleash Support to Arc
  3. Tick on Do you wait for Max Unleash Seals?
  4. Select Oshabi Bloodline
  5. Allocate The Primal Owl
  6. See incorrect More Multiplier and damage
PoB for PoE1 build code
https://pobb.in/06T0iKY7XS84
Screenshots

Without The Primal Owl:
Image

With The Primal Owl:
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Arc and Unleash Support setup with six seals, Oshabi Bloodline, and The Primal Owl using the linked PoB build. Trace the calculation that produces the More Multiplier and compare it with the issue's expected formula, where the first hit has no Primal Owl bonus and each reoccurrence increases it. Done means the displayed damage matches the reported 5.512 multiplier for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.