Mana Cost per Second with Max Unleash Seals is incorrect

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-game using Unleash Support, I believe it should be calculated as

Mana Cost * Cost Multiplier * Hit Rate = Mana Cost * Cost Multiplier * (1 / Time to Gain Max Seals)

So the value would be 15.13 Mana/s (with placeholder stats):

• Mana Cost = 23
• Cost Multiplier = 1.4
• Hit Rate = 0.47
• Time to Gain Max Seals = 2.13s
• Cast Rate = 1.5s
• 23* 1.4 * (1 / 2.13) = 15.13 Mana/s`

What is the value from the calculation in Path of Building?

In PoB using Unleash support, when Hit Rate is based on Time to Gain Max Seals (https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/9601), PoB calculates it as Mana Cost * Cost Multiplier * Time to Gain Max Seals (calling the time "Full Unleash Speed"). It appears to be using max seal time as the rate instead.

So PoB produces the incorrect value 68.57 Mana/s (with placeholder stats):

• Mana Cost = 23
• Cost Multiplier = 1.4
• Hit Rate = 0.47
• Time to Gain Max Seals = 2.13s
• Cast Rate = 1.5/s
• 23* 1.4 * 2.13 = 68.57 Mana/s

When instead, Hit Rate is based on Cast Rate (currently when Cast Rate * 1.1 > Time to Gain Max Seals), PoB calculates it as Mana Cost * Cost Multiplier * Cast Rate * 1.1

• Mana Cost = 23
• Cost Multiplier = 1.4
• Hit Rate = 0.47
• Time to Gain Max Seals = 2.13s
• Cast Rate = 3/s
• 23* 1.4 * 3.3 = 106.26 Mana/s

How to reproduce the issue

1. Select Arc as the main skill
2. Add Unleash Support to Arc
3. Tick on Do you wait for Max Unleash Seals?
4. See incorrect first Mana Cost per Second
5. Enter into custom modifiers 100% increased cast speed
6. See incorrect second Mana Cost per Second

PoB for PoE1 build code

https://pobb.in/m6HgOinymvTt

Screenshots

When Time to Gain Max Seals is greater than 110% of Cast Rate:

When 110% of Cast Rate is greater than Time to Gain Max Seals:

Reproduisez le problème avec Arc et Unleash Support en suivant les étapes indiquées et en utilisant le code de build PoE1 lié. Commencez par le calcul du coût de mana par seconde de Unleash, en vérifiant à la fois les branches max-seal-time et cast-rate. C'est terminé lorsque les deux branches utilisent le comportement de hit-rate signalé et correspondent aux valeurs de Mana/s attendues.