PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
DPS preview when swapping out lynchpin gem shows output for next default skill, sometimes misleadingly
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
- What happened?
Messing with supports for a minion, I had their Infernal Legion DPS selected for Main Skill. When I then moved to the dropdown for picking a different support in the Infernal Legion slot, the preview tooltip claimed that changing to Elemental Focus would give me an unrealistic +1M DPS boost.
If I select the gem previewed, it changes my Main Skill to Minion Instability, with the resulting DPS matching the "+DPS inc. Poison" part of the strange preview. I'm not sure where the +1M Total DPS comes from.
- What were you trying to do?
No clear use case here--you typically don't want to be swapping out the gem that gives you your "Main Skill" DPS anyway. It was an accidental encounter while exploring gem options. But in a less obviously-wrong case it could mislead someone about their DPS prospects!
- What steps will reproduce the bug?
- Create a new build
- Add a minion skill and Infernal Legion support
- Go to the dropdown from Infernal Legion and hover over a different support. Note the possibly strange preview numbers
- Select the new gem. The Main Skill changes, with its numbers resembling the preview.
- Does it reproduce every time? If not, why so?
Yes, although the specific numbers vary wildly depending on the rest of the build's setup.
- Additional information:

Suggested fix would be to have any such preview say that it's removing all the DPS, making clear that you're effectively deleting that source of damage.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema creando una build nueva, añadiendo una habilidad de minion con Infernal Legion y pasando el cursor sobre otro support en su menú desplegable. Sigue los puntos de entrada de la vista previa y de selección de gemas para ver por qué cambia Main Skill y, después, verifica que la vista previa refleje claramente la eliminación de la fuente de DPS actual y ya no muestre totales engañosos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- desktop
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100