PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Banner Scaling Bugged? (Dread Banner)

Open
#9,368 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When I use Dread banner on my character in game, my block values are not accurate to what POB shows they should be:

Image Image

I'm not sure if I've missed a conditional but I just imported this character fresh into pob to make sure and did not touch any config settings

How does Path of Building behave?

POB values seem to be slightly higher than what they should be, they should match in game

How to reproduce the issue

Click Dread banner -> Compare with Imported POB

PoB for PoE1 build code
https://pobb.in/tUehoFHc6jhK
Screenshots
Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by importing the linked PoB build code and reproducing the Dread Banner comparison described in the issue. Compare the displayed block values with the in-game values and trace the Dread Banner calculation; done means the imported build's values match the game without extra configuration changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.