PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Modifying equipped flasks does not show negative stat differences
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
If I modify an equipped flask by lowering the values of some mods, I'd expect the stat differences to show the results.
How does Path of Building behave?
If I modify an equipped flask by lowering the values of some mods, the resulting negative stat differences aren't shown, only the positive ones.
How to reproduce the issue
- Craft a
Granite Flaskwith the mod˙50% increased Armour during Effect - Save it
- Modify the flask by increasing the armour value - you should see
Activating this flask will give youand some positive armour increase - Modify the flask by decreasing the armour value - the stat differences aren't displayed
PoB for PoE1 build code
Screenshots
Starting from 50% increased Armour:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in Path of Building with an equipped Granite Flask, first increasing and then decreasing its armour modifier. Trace the code responsible for displaying flask stat differences; done means negative differences are displayed as well as positive ones.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100