PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Precursor Emblem Iron Reflex at max charges works even at 0 charges

Open
#8,909 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: behaviour
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

The ring should only provide the Iron reflex keystone effect only when frenzy charges are maximum

What is the behaviour in Path of Building?

The keystone effect works as soon as equipping the item, even if you are not at max charges.

How to reproduce the issue

Add Grace
Add precursor emblem with Iron reflex at maximum charges

It should convert evasion to armour, even when frenzy charges are not enabled.

PoB for PoE1 build code
https://pobb.in/mNp-b5w7rpVv
Screenshots
Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the PoB build code linked in the issue and reproduce the interaction between Grace, the Precursor's Emblem modifier, Iron Reflex, and frenzy-charge state. Trace the entry point that evaluates conditional item effects and verify that the keystone is inactive below maximum charges and active at maximum charges; confirm the resulting armour and evasion values.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.