PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect damage breakdown when using Winds of Fate staff
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Linux - Wine
What is the value from the calculation in-game?
Will hijack this to post system details :
Up to date Tumbleweed KDE
- Kernel 6.15.0
- KDE Plasma 6.3.5
- Wine 10.0.4.1
- Wine-mono 9.4.0.1.7
Running wayland, but not forcing it on PoB.
What is the value from the calculation in Path of Building?
Example 1 - https://pobb.in/G2Izw_kkrBa4
Its a simple Witchhunter's Judgement ( Oshabi staff ) with Storm Brand and Brand Surge ( the skill oshabi staff gives ) is showing +5 min and +5 max dmg from something called "Sacrificial Zeal" and does not convert the dmg at all.
And i SWEAR that pob used to support Brand Surge ( even the escalating properties of it ).
It feels like in some git commit, someone accidentally rolled back all the work that was ever done on Brand Surge. Even the AoE used to show the ring.
Example 2 - https://pobb.in/EmZMxrFNoHqs
It does the conversion correct, but everything in that window is still not correct.
Example 3 - https://pobb.in/w9F0oGbpqDeI
An Necro with Unholy Might node and minions. I'm not sure how conversion works here, but i assumed its Skill > tree > item
Still the same issue with added dmg screen being wrong tho.
How to reproduce the issue
No response
PoB for PoE1 build code
They are linked above.
Screenshots
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Lade die drei verlinkten PoB-Beispiele und vergleiche die Schadensaufschlüsselungen für Brand Surge, Sacrificial Zeal, Umwandlung und zusätzlichen Schaden. Verfolge den bestehenden Schadensberechnungspfad für diese Fälle; die Aufgabe ist abgeschlossen, wenn die angezeigte Aufschlüsselung und die Umwandlung in allen Beispielen mit dem gemeldeten Verhalten im Spiel übereinstimmen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 35/100