PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect damage breakdown when using Winds of Fate staff

Open
#8,645 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

user-interface
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Linux - Wine

What is the value from the calculation in-game?

Will hijack this to post system details :

Up to date Tumbleweed KDE

  • Kernel 6.15.0
  • KDE Plasma 6.3.5
  • Wine 10.0.4.1
  • Wine-mono 9.4.0.1.7

Running wayland, but not forcing it on PoB.

What is the value from the calculation in Path of Building?

Example 1 - https://pobb.in/G2Izw_kkrBa4

Its a simple Witchhunter's Judgement ( Oshabi staff ) with Storm Brand and Brand Surge ( the skill oshabi staff gives ) is showing +5 min and +5 max dmg from something called "Sacrificial Zeal" and does not convert the dmg at all.

And i SWEAR that pob used to support Brand Surge ( even the escalating properties of it ).

It feels like in some git commit, someone accidentally rolled back all the work that was ever done on Brand Surge. Even the AoE used to show the ring.

Example 2 - https://pobb.in/EmZMxrFNoHqs

It does the conversion correct, but everything in that window is still not correct.

Example 3 - https://pobb.in/w9F0oGbpqDeI

An Necro with Unholy Might node and minions. I'm not sure how conversion works here, but i assumed its Skill > tree > item

Still the same issue with added dmg screen being wrong tho.

How to reproduce the issue

No response

PoB for PoE1 build code
They are linked above.
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the three linked PoB examples and compare the damage breakdowns for Brand Surge, Sacrificial Zeal, conversion, and added damage. Trace the existing damage-calculation path for those cases; done means the displayed breakdown and conversion match the reported in-game behavior across all examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.