PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Elemental Penetration support cannot support active skills from items in PoB, but can in game
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
In-game, Elemental Penetration support can support active skills from items.
What is the value from the calculation in Path of Building?
In Path of Building, Elemental Penetration support cannot support active skills from items.
I believe this is because "Elemental Penetration" is tagged as "fromItem = true" even though there is a way to obtain it as a real support gem:
https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/7984c8f532f88a6d0b4f9d70346fde7f2c7cc9ed/src/Data/Skills/other.lua#L1279
And there's some special casing to avoid having support gems from items affect active skills from items:
https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/7984c8f532f88a6d0b4f9d70346fde7f2c7cc9ed/src/Modules/CalcTools.lua#L93-L96
How to reproduce the issue
- Add any item that grants an active skill, and can be supported by support gems (for example, "Relic of the Pact").
- Add "Elemental Penetration" as a support in that item's sockets.
- Observe that "Elemental Penetration" is listed as "Cannot apply to any of the active skills".
Character build code
eNqtW21P47gW_jz8CqvSle6VLm3TNwYEuyrlVYKh28Ls3U8rk7itFyfuJA5MdzX__Z5jJ2no1CFpChKk8XnOm-3jc07S01-_-4K8sjDiMjhrOM12g7DAlR4P5meNp8erw8-NX385OB1TtXiYncdc4MgvB59O9TUR7JUJwDWIouGcqa8pp-6fwGlJA7VgMrinf8nwWnpnjS8yYA3yTAOPq_STK2gUfaE-O2tMXQA3CI1cFnij9f2EcEFD6ioW3qHUYazkvfRgVIUxjPqUB1PpvjB1Hcp4qZV65ezN0Nzejx8mjzmVeJBXCSz6dDoWdMXCqaKKRPDnrDEEx9A5u-EKWFERA59uu9nu946cQb_b7XW7jVYh8jwOI3VBfbisymG6ZMzLQJ3mUb_3udM-7g4G3WPHBhqH7HI2Y67ir2wUcjVa0MBdi-7bcFVp72Oh-FJwFmb0TtOKuPmJudNu24gfpaLiYjzNaD-D7cf97qDT7Tvtfr8YJ9czZZXwO1eLcwHe3UEKYm_nAVdsR_BY8kgGNezLQ60mjmIhYJ-Wop2wiIWvVPH3atl5S_-ZBzt5bySl8ORbsBbS7A7seyhk9GFm1vOEejyO7pkKWZRDWyXd04COZFRiNSDlmIUQcFQlwJS5EmJUVRkVkXd8xspTVrIjAVTVZjc7Lqdl6Soz3k2hCYTkcpRTGYuSlGodDjtWqgv2vQTVbaBKUE3Ytzyh4xzbpb5KpQ_Xj6zQgebyZrw-CY6aTq_zuX9k_lrPnsUq4i4V9_Q792Mfgv4jfWFrgf3P9mU1X6gA4pUN2h3YoFc8ZNVRIwhDO6AWVEbVYbhpMrJBu-C8d0-Q9jZwy-3EpyDUoTuXJhT5eMYmsD8wL3kWrCRiLSLZZRnueNAcrH-OisXOWZDIXpUz7Y4xd3ENCd2EqlzW0Bz0-8fto07vqN1xnKJou7av2OFIW8rhSLjN4SUBm-4rSIAQaHFZ87gItN1p9sgZsHC-mi44E1416lSxEV2WCIro5jy6lLvfi6u0fvLQii75nYZeuaOjqk6vNMoHX2dQ7C5DXm5hMkhlAeCxjRy7bS8S5F9YIohqsGHoyzgsOeGGuJQB6blhyqQJ82K33EGVVTrnAsq-smZkKNBTiErQoVLUfbmQ3ry007SQSoj3-k3j5RJiCK6GsgzwSIScnucylsNBCeoHWMqldjSenuUFrKlLC8jygfJSNiDlbcEzvYIxa_LSIrIJvYdg4cMhoCv7e7mONNaT7ArKuFI1mSYsWRuO5RtovsB2TVSNGnKfdb5jVSVkwd-r0vzfkZcScBl4cYhbobSMTcQ2MY_ch0AaRRdUUeIlyfJXGnIaqI7uJUWMhu7iDqb-igrxDJHgrJG_i582gE46t6ct3S7Dq1t_KUNF2Hf8N6ahWp01ZlREzBDqO8AnUjzQNTmEHSEaZLqQb0PvFa14hCo6SkGELpcs8N7xeAwZIzQNIi4qoW3ED8SnkYIzy6zKCJXOddtuPXQjCSQogLnh524XTcSyioar4XvCgINeUJCzXNOv00_6eYYTiv10-jS50xefFkoto5NW6-3trbmkaiFn7DscQ01X-q0lgEDhw-iFC3GIbFtD-DmfD_WPZtRKOZ2aRl_UMp9wL4YcdDZz2UJDtdfRE3jxRSoW4RjeTD-cTlFURCKYiGvmR-cr2D9XmDZsNDkSVyL1lCmzGPKYtAPpsRmNBd7_LaaC48y283fvTLM0kKGflUnACmYWw7zh-LhaouuHd3dmZChUwgzFpdNspjNRiHAvneLkpu6FDtdaj6hwI603D1wRe1BjJKElmUVBn1EztCuGRBXKT8X8E-dkwgR3iZwRtWBkDH74L5nCIU1-p4GHjWIsJbzU_EhIzKEYXcqAOI1NJTIdP52CKQn4WshnKjqpGlk3Wa8CXENwQEtvSt2QYuh8Cvg3FPUt5988IyfVZUM1V8aBSoQEwMlsC82bZMwbyWpqaXU_dqfm9pFDq_oI0XYvGSaJmzpg_Jz56KV7pqgHkauF8xa1cKm01mvqUuhzh4oxC5gKaZpe6RiF8IR0O102FYVU-RlJrhFzYRZ_pVly8nOUSSN5cT_NVHIJu0Hve7Oz8VLPlaa4DZax0pzPGj6P3D-f49kMHw6AiSrUzzsur64uR4-3Xy-TQyEP0W74M4j9Z2x6m__ro3vKdNJKovg5Mpdnja-cvWlFLmB2uIjQQCHoMmJZuNZbN9FcAK6Am6a64dnThO281gR2TpffWQinyxyqHTfkzKpXNv6BUkYgVkJ4iNq4YWvezsik1iM4m0ylZvGUfiZi54KPJqzm4GABFs5lKqySk9EPPKEweMOy5TPuYv5RPOUY6g1VgV9cF1IXd1Uw30ldYOehn3XYGJhBO9g8r7Chk9ECr-pnJVavmlE7_IK51Gq7GbSDs-JfBvoJ3nYuGVUBpy8y0IscNs2QC4xH1pmFeJWR2Bk-wHkaJimYjdM9xKiUpHDjhPw5VvZtnKMo8JVuUlo8hGN2qGm3WWzAsYJI9K4FZXFonsbOyrRurIGsCGrqOav_kuqwYAqSxojF_Wa0wAlpb8hifzJcsEl0_B2-Su6ZDoFlu2yQFQUMyK7rs9Ftj_psNvsg9TleQYHyYp3vZNQOf1Ic05stXEwaU4oJbqp6HHBv1ePwCMmrikO2M4PJZiayxk6Kc5Csdt8KTkeLIkdS0u_MwTQedobrvsjOaB3_ITdmYEHhAZDRFOwPFQcXcZqH12Kl1doeSNbWVeJljsKtllbmaDZ48titKAYYkg8YwVl-U5AtluOU9fZuGBX4cocU9Rj-9HixDjN8PhEvoVRP2T1sy9HX81DSe1JFwFM3tC7wMUhdHwbMX21hZNfrtJVWdbrVhXVW0oebqhCL7r-l9P_QpSheJW2XbtJqgYz7gsO8hXq9pXKQ8H9pD_FUl9FJ3wevs7aPnUEcMfP-gSnuNSIt5jW_tOCGwr2Rb9lM4LZanZCnL7e_PV0e_NRyOcg6Lgd3jM5jBqRCcZ-q2D9IGo0nZBwy0m12nGZ7fW8Uh6AjMNC1JfNINtI5-CfR5sT5MV3yEIobz8jIBjo_1oKTFhQA2wdJ6-2EnB_C74H27oR9OyHd9gGUSaA9x9F3Iv6BWD1nJ-1m_8e_nf6hc_yff2HnJGQUpproE56YWc7Lf4c6Ouw4dtQ1kKqIaGWIQzY6O0TXWwd_QCJGsAzEx00E1gp_YcSUT4QDOHZfVuRtwQUjsEbv5BvBU1p3Gu6lN0FliFbJvHqUTGLSi7BSdD6k6H5I0Uv2j-7vZCsKe3-2Zfe-KSikIlBp-ePnp8kd7hDT07gWULXDrsMh07BtFQPWjasU4nwEOZcQL8jweRVF6HS9eEi_gsxzJtQmvlMBr7MY0t3BSjJ9o8tN0b1dGNUwP-HR2QOP7QYN9mDQYA8G7cRjm0FOlcW1bXV29-CRzr6sqbLebhikW6qWP7ZstkFtDTqVOdQW2d2X__t7WAzOHraHswc9ehVXwr5CTKfujuztwYHVz4y9hdhuXfs7NbdwNQW8FTFdqzpr0OQWdThs39j92hwG-5pWZ18xpvrSrO_HXu257O9nUVUxfujHgqk9RMLuHgJKt-am7NXEO_vx_84nZeVF26uM2CWLqunVft1Yvadp6e0ruOwtr965hKqAm_BgXmkKt4emzn7mYG8nxT4Kvt5uNlV1fv0zfk_JRr-2IvWPuEHVYFA3ePws0PR80hdbdGNSv9cigxmfJy1K8yFpUmpQduddH2gsqMsWUngsTJRg2HxNvmqavtNy1M50twDyXxdNUX07ZroA46b4gkf005szVhnp6s3oOwUCXKmbv9UkoBXp2zQppltgup996RW_yMlC5mmJI3xracrELCe5_4Ho9--851z_AS55R14KofuE-Tn7AJk9ZU4RgwJZEZ9z8TDTz7jARv2gbvONp1a2xExHXn_65eC0tflV8f8D7Kzt_g==
Screenshots
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con la definición de Elemental Penetration en src/Data/Skills/other.lua alrededor de la línea 1279 y el manejo de los supports de objetos en src/Modules/CalcTools.lua alrededor de las líneas 93-96. Reproduce el problema con una habilidad activa otorgada por un objeto, como Relic of the Pact, y Elemental Penetration en sus engarces. Se considera terminado cuando el support se acepta para las habilidades activas de objetos que cumplen los requisitos, de acuerdo con el comportamiento del juego.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- backend
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Tranquilo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 68/100