Penance Brand of Conduction calculates its damage per hit rate, not per duration

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation in-game?

The new Penance Brand of Conduction does not do damage each time it activates, only when it detaches from the enemy. PoB appears to be calculating its damage each time the skill activates and not once per duration.

Example:
Penance Brand of Conduction should see a DPS decrease when linked with Increased Duration

What is the value from the calculation in Path of Building?

Example: On a level 1 character with a 20/0 Penance Brand of Conduction, PoB shows a Full DPS of 8725 (Average Hit x Hit Rate for this setup). This value is incorrect, because PBoC only does damage once, when it expires.

Actual DPS for this setup should be: Average Hit / max(Cast Time, Skill Duration) or 1308 / max(0.75, 0.528) = 1744 for this simple setup.

To further show this, Penance Brand of Conduction should see lower DPS when linked with Increased Duration, because it will take longer to expire once attached and therefore longer between damage instances.

When linking PBoC to Increased Duration in PoB 2.39.0, there is no change to Full DPS at all, but the new DPS should be: 1308 / max(0.75, 0.825) = ~1538.

How to reproduce the issue

1. Select Penance Brand of Conduction as the main skill
2. Take note of the Full DPS calculation, and the Skill Duration
3. Make a 2-link with Increased Duration Support
4. Note that DPS does not change, even though in game this setup would do less DPS due more time between damage instances

Character build code

eNq1W9134rgOf579K3J4n_KRgbZ76O6hn9NzypQL7czdpzkmMeCtE7OxQ8v-9Veyk5AyOE1ILg9tiKWfJdmSJSUM_3wLuLOhkWQivGh1Tzoth4ae8Fm4vGg9P91-Pmv9-cdvwwlRq8fFZcw4jvzx26ehvnY43VAOfC1HkWhJ1fcUyf0JSGsSqhUV4Zj8LaI74V-0vomQtpw5CX2m0m8eJ1J-IwG9aM08YG45RHo09K929xPCFYmIp2j0gLOOYiXGwodRFcUwGhAWzoT3QtVdJOK1FmrD6KuhuR9PHqdPOZFYmBcJNPo0nHCypdFMEeVI-HPRGoFhyJJ-ZQqgCI8Bp-t2zk5Oz8_O3P7APR202oWcl3Ek1TUJ4LIqwmxNqb9jOnHzHxsTSPqeb3AyyH1ObXyTiN4sFtRTbEOvIqauViT0diJbhaxKO465YmvOaJTTrF-gzR54t9OxET8JRfj1ZJbRnp32-idur98_7Zx3T91iPrFb4c5HlPlJrMRXMefgKaVop1TSaEMU7P1y2CKYs5D6o82y8r6MKHlcmLWeEp_FckxVRGWG0zs5s_FeRuC2I6WItwpoCOzhkmrujNktZH1i3ov8mHZMQnIl5G5BeqdFpBMaQbBQ7zg6HzDMqCcgvuRZ3EGJSQ6zWmd7YAtanrKSIglDVWmO0-NmVpauMvBxAk0hnpajnImYl6RUu5jUK3DVf_KEA6uzXNO3EnD3oSo3aZ7wvGDSjVD6BC0Vy26-TjLK_vlJt-u6nc6X896g27UeFKutZB7hY_LGgjiACP1EXuhuwkHB9luuVAgh0cbqWtW6ZRGtznUluH8E14oIWZ0NnauEEeBw9n5H2vvQK-exz2GkT4f8mV7IMAU_wuRjzmlJjt0UiTeWOW7NVEsaJvNty6nzQKm3uoNMDabKp1WFEXu3SYsNi7SlDIuEBwzbL8lQwUzIaDHTyXkRU2VD3YQ0Wm5nK0a5X406Fe2KrEuESTR0nruUwd9PV2nX5FkrG-UHifxyx0lVqTZE5gNtd1BsMENebnNSTikw-HQv-e3Ys3fxN-buvBrbKApEHJVcckNcSoH0jDB1z5T6sVfuULrkUL6VlR6k4rwSh05dX66Fv6SVJqnEkZVRmnUWr9cQNXDtywLgYQcFAcvlLJ8HJagfYeOW8mA8F8tPsKMuPUF20pefZY-lvC54WldQZkdeeopsQccQGrDu0QX2WORqc-viQA14REWq2Q6XmQni7IVx7kj8OyERsLQcCd7pUX1lnJCGuN8cXXk5YuFcQXa954gl5ZmIV7DVCvs7soT356ghj_q43ruNaPjvtjT-O_JSE9yA4hEao_Qc-xyHpnliAQRqKa-JIo6fJN7fScRIqHq6-SQpibzVA2y2W8L5HGKPXp7sLn7bY-ymu2nY1v01vLoP1iJSDn3Df7jc24vWgnBJDaG-AzhSsVC3ECDQcd5yZivxOvI3qMWTEFymTA5Zr2nov8N4iih1SBq2PBRC64hfnIBIBWei8QOJQufac_c-mtEJBQgACdTZmeuiiljKkWg7ek8YMpBLwVy5LmHPTRqABgmn_TR8nj7oi08rpdby93b79fX1ZE3USizoGxxzJ54I2mtgAoE_azf4jLDtEXwulyP90UDtFGloOoOybb6h90cMZDZr2UZFtdXREnjxTSgqcQxvpl-G2u8k-Fqk7mggL7fgi7eYmOx6MtprE1Mi9YwqsxnyPGnL0qcLEnO8_5-YcIYr28nffTDd1VBEQVZyARSsLB4sBvFpu0bTjx4ezMiIqwQMp0uX2SxnIpDD_HSJk5u6eTraSX1FuCe13Cz0eOxDvZKEnlR0TuYoGnaLsdTw813YHFA2z6chiJMQ33ExJ7yXQRktof51ljTAfTCmivjgV-17BTq0UZG2hoOrJLDpuIZOqf0GmfIDYIS_WiZAajyyDMiMLRk3A__krJ1cI9m1MXzrnZjdVMw9RT0Rh2ZpQxIkblMUdNsNmSFb-Fvtl1fEHH2ZGXa3E9KcHZI7ec56pkhCyiFbmEkcnAXO9ebVh1Q0okSCx0GoTo-1zAq_jFqNcQDn_2aTbC4nmywJSGZ7J8EocVMdkEzIwUvtk5riPlzHSsNetAImvZ_zeLHAxxx4-Ef6yc3N7e3N1dP995vktMqzaAv8DONgjm1483-Xxcyo3q-OjOfSXF60vjP6qgW5hiVhXKJ2nJO1zOmLMSWRnANfAZqmgvItfS5yGGtHYEe6eaMR7i4o87yIUatc2fgHQpkJsQTE092Ghg8L7ECmysBtPyXKimGe0thR8GGJVR0cLOCFhIFw68zJ6AeWUHiqwJ5lC-ZhYlS85HgGGaoCu3ge7HlvW7DeSYlkx7jk-tnWYQAzaGeeCCbRuw9zJ6MFVl2GzL6eyaid_Zp6xKq7GbQzZ30PEeq2x2GUjKoA6ZsI9SYHpxkxjuWMdWVvOM1I7ICPakWjJDe0IY0hRqUkhY4TsXms7G6coyiwle7EWiyEY3ZW02u06IBjBZHoXffNYtA8jR3K9KysgayI1ZS2VvslhXLBEiQdIYv5zWiBEdKmmEX_ZLjASXT8HW0E802zxOIue2RFAQPS_vowugNUH2a_JVQf8RYqpxfreiejdvZnxTC5OYBicppSIOhU9RDQt-ohTPcTiR3vtDiFyHoCB5nT0SLHT1oFRyOYhsbR7LrfcjS3Dt-Q2FLQoDB-ZzQF21vF4S6JrgWlxTocB3baVcIyJ9lBTSsjGv9MHg0WubAh-QAIjuKvBcleOaSsS_mVEq5WEyF4PcBfHoHW0lMoCRXxNT5jqakoPqKJ1wCWSvZ4KFvfLek-6rCd1lG664WVTdKSm6kI-xn_ChH8pUs_vEo6MG7SdYEc95qBqSO9RdJ5kPC_aTtxqKvVpAWE12kHKJbUvOPwg5I1FKR4Gztipj4zhFai9y0bLpQD6WYwmT9PH1BoU9gZHge7NsqU0J20vrSxXFKunNF8KyXhjumROb0K_OmU-xj96hi9BjC6zuyVrPeBBg0oNGhAoSoYlwJ8Zh_ArQDwlULE-2Vt6-6No8xwaE36DaxJtwGMLxUN0tSebMLJqmDoFKqS1Q_uwF7N_eNWFrnKAt1xsaGyzjY57DWDygiV1ezWVrPK2o6CmFPVwBZ0GwiLbm3Vv1Q2d5V9PIUM7Rh_NYGvsnJ1XbRf2Rj1j5VebYT6Mnypa7gvTcV2t5Ik_tYxnZXm41a_qdO624xGvbpLVDmDqh1aBs1o3q8tiFs1YnXrGrvbQGxvzKf6zazDoGb-Uj8bqZtBNeSKblOhoTGgY0qL42zR1J5saCmO9pGaO6mx06HXQKBoAqPblEKNRa1fgYbtpNWje1G6V6Qf7otwwZbp22geXQnu0yiZgoY02Ca_60sf15_m3zk_RJ__aV7K1C9mSb0jeyWg9_EU6UP8lMe1iyXxBZzHhW5YzxTRXff9tw9-5Qqynwz-YNjJpf5MP2DH1ytmlC9yGB-ol7yPLDjXP13L27KYMXuulTLkf0h5iOH9G9C5idIWZLLaw_b-72r_B5MSFYQ=

Screenshots

No response

No file or test is named. Reproduce the issue by selecting Penance Brand of Conduction as the main skill, recording Full DPS and Skill Duration, then adding Increased Duration Support; inspect the main-skill calculation entry point for this skill. Done means DPS uses Average Hit divided by max(Cast Time, Skill Duration) and decreases when duration increases.