PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Leadership's Price and Corpse Pact

Open
#7,098 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: behaviour
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

Having Leadership's Price and Corpse Pact means that spawning corpses under mobs is not shocking or chilling them.

What is the behaviour in Path of Building?

Selecting "Spawned a corpse Recently?" while having Corpse Pact (Necro) and Leadership's Price equipped is showing damage increase as if the enemy were shocked. However, in game (tested in Blood Aqueducts) spawning by using desecrate did not chill or shock the mobs.

How to reproduce the issue
  1. Add any skill that hits.
  2. Add Leadership's price (Balance two highest stats so you get the conflux)
  3. Be Necromancer with Corpse Pact allocated.
  4. Select "Spawned a corpse Recently?" in calculations to see that damage does go up as if Shock (15%).

Try in game to see if spawning Corpses under mobs shocks or chills them (it does not).

The POB below has Shock (23%) which increases the damage the same as if "Spawned a corpse Recently?" was selected.

Character build code
https://pobb.in/yYX55oMpqGa0
Screenshots

image

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the calculations entry point that handles the "Spawned a corpse Recently?" condition, then reproduce the issue with the linked PoB build and the Leadership's Price, Corpse Pact setup. Compare the shock and chill effects with the reported in-game behavior; done means the damage calculation no longer applies those effects when spawning corpses does not cause them.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.