PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Setting Exerted calc mode to Max Hit removes attack speed multiplier for impale damage in the full dps calculation
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
in-game behaviour is not relevant for this bug report
What is the value from the calculation in Path of Building?
When changing the Exerted/Boosted calc mode to 'Max Hit' instead of 'Average' the impale portion of the Full DPS calculation loses its attack speed multiplier.
The example PoB has custom modifiers to disable any effect of Intimidating Cry. Additionally, it has a high-quality Anomalous Impale Support gem to guarantee 100% chance to Impale. The Exerted calc mode is set to Average and the Full Impale DPS is 187,622. The calculation tab confirms that attack speed is properly taken into account for impale.
When we switch the exert calculation mode to Max Hit we see that the Full Impalee DPS goes down to 155,317 and the calculation tab confirms again that this time attack speed is not taken into account. The correct behaviour would be to have an impale damage of 155,316 (to still have the correct number for Combined Total Damage), but when calculating the Full DPS to also multiply the Impale Damage with the attack speed multiplier. Right now only the Average Damage is multiplied by attack speed, and the Impale Damage does not have a multiplier.
How to reproduce the issue
No response
Character build code
eNqtW19z4jgSfx4-hYuqfdoawOZfkkp2i5BkkqpkwkFm5u5pS9gCtCMsxpaTsFf33a9bssEQZGzsTFXGoP61ulvqVnfLufzzfcmtVxqETPhXdbvRqlvUd4XH_PlV_dvL3eez-p9_1C5HRC6eZ9cR4zjyR-3TpXq2OH2lHHB1S5JgTuX3hFP7L-C0Ir5cUOE_kb9F8EV4V_Wvwqd1a0p8j8nkk8tJGH4lS3pVn7gArlskdKnvDbffx4QLEhBX0uARZx1EUjwJD0ZlEMHokjB_ItyfVH4JRLRSQr0y-qZpHp5Gz-OXlEjMT4sEGn26HHGypsFEEmmF8OuqPgDDkDm9IUv4DdwIj4CV03F6Z-eNXrvrdNr1Zib0OgpCeQp-sqLU20DshtM6M5GOAno7m1FXslc6DJgcLojvbqfrNWwTsjj1U8QlW3FGg5Rs_b4Jcv-Bv91qmYhfhCT8ZjTZGuq8bffOG63-ebvf7naycUJucMYZfjC5uOZg2BNmQezD3GeSnggeCRYKv4R-aahRxYflivAdEe2zfs9xGu0ebDvb6Wbq9wHcOQPp7Ean0-61O8YdOIw4h7CQS8AxDWnwSiTbtYWRfiiWU-bvLlk-qQYBJc8z7Rpj4rEofKIyoOGGjdH5nohPhiLc7qh-FuWIBhCu5A6gdQQwoa6ACJeGnDU63V6OeQ6jjRM-shnNT1lIlxhQVJrT9Lid5KUrzPg0gcYQ0_NRTkTEc1LKbVx1MlzoV5rQ7hqd-oa-5-OXJuybg4svc7C7oa9CqnP8mLoqst3ejzaU3fOGbbfbrVbnHIKV8SQaLdYhcwl_Iu9sGS3hlHkhP-l2wl7G_psvpA-xygRtG8PJHQtocdRQcO8E1IKIsDgMvSuHESC3cC-Q9sF387nsNz9QYTuVkvQyAWNwJMyAppzmRGyniN0xT8qgp5pTP55vnU-dR0rdxRfIF8dE0nwxe7tFs82KtLnMioQHzNrNCShgJAQajNQ4zwIVNNOtT4P5erJglHvFqBPBhmSVI0aimdPoXObena7QjklDC5rkBwm8fCdJUZleSZgOsXYv21yaPN_GpJAhA8Cje6l7y1yAiL-x_ODFYINgKaIg54Jr4lwKJKeDLrvG1IvcfMfRNYfyMa_0IBXnhRADKYn780Z4c1pokuKISbRaQaDAJc-Lw9MNUnOWylI-93JQP8N-zeW2eBDmn2BLnXuCzdGef5Y9SH5d8HguoMyWPPcUm4r-CSLCEiK9agg8iVRPwLg4UI0Vr5YU6nCRGTOc_GScWyH-HpEAIHUrBJ90qXrSmnJKXumRAjc_O6S0dFFqnVDSjsQbWHuBjakwR9hIUUPqdbxKvAuo_886N_8d8lwT3PpeFKD75p5jH3Fomhe2hAgfhjdEEsuLc_XvJGDEl47qmoWUBO7iEbbrHeF8CkFLLcnmW_y0B7ST_XjZVI1BfIKFE4G06Dv-h0u8vqrPCA-pJlTfAJ9QMl-1AyBCcl63JgvxNvBeUYsXIXiYgCyyWlHf2-HxElBqEeUneEqgEEpH_JDuIj54aDRrSUIJx6v2rRDV8AUIAFnX2Vm7XbcksEt1MB0nbk5qOHL-dPlt_KgePi2kXIUXzebb21tjReRCzOg7HIENVyybKwCBTJ_V7v6MbJsD-LmeD9SPYtRMOF3qrmXY1J8wRAQMxNLL1URdlGFRWXz4KiQNcQy_TD5cKncKwYUC-YUuw-s1OMwdpix7LZTYWkg9oVKvdxqTtFM9OiMRx-__FRHOcPFa6W8fdefXF8FyU4gBK1g8PH00x5f1Cq07eHzUIwMuY2Y4XbKSesVigSzmJasYf6kau4Ot1EPC3VDJzXyXRx5UMXFESUTnZIqiYScbCxAv3SFOMdrM8-kSxImJv3AxJdzZsNJaOq36zridjKsFxu2RRL5fWj_86kbbqm7N6RI_P1FJPHC65oME7ZtogqYSBJ724MrWe9K7IvL1evlkGW_3GNasTI147XTM3dEG1o4G4KjUzlZos_h7PK7q5-e5dIpxsTdoCx3fDj7jFWwI5FKZLR98yZYMDAQJxhCT-hP3holP3k2SxlvI4INp40dwPxVodCjBR2VcRfHgryKpmF7Vlyx0_5pGsxlereBZHajbotu7u9vhy8P32_igSUOUUf7yo-UUbw70_9sUZkJVhm6F0TTUj1f174y-KUFuwDSMh6gb52QV0s0RoGJFLDkHXAY3RXXPNlcxh3ltCcycbt9pgJaE0s4NGDXKtRk_IpSeEMs-PJhN3PB6w8xIVxZDON10WWqwlLpSMnPB-x2jOjiYgU2c_TA47dJmS0g8LWDHshlzMafJXnI8WzRVhl1cF9Ihd52x3nF9ZOah7otMDPSgGazvfEzoeDTDquq-yWhVPWqG31CXGHXXg2bwptMhfDCTicuGKoPTV-GrTQ5OM2Acaxnjyt5yuiExM3yWCxrESZyJ0xPEqIQk03ECNo2k2Y1TFBm2Un1Xg4VwzAzVvUWDDjiWEYl2-m0Gg6ZpzKx0n8oYyLKguq412i-ukjOWIO4CGcyvRzOMkDTCDPrHwxlOouLv4FXACak6JQZ32SPLChiQzpdno7o-5dns94PKc7yDiuincb3jUTP8m2SYvBzgojOYXEzQqcpxQN8qx2G8n0hssePsFELFL8gAKRg6M4BtaDLWV0b-DRxyMmNtc7JSYh12hK1qhXjpUH5Q08Ic9QaNb8Ky9rAmOcIIzqL7jGwnH6dNj-6eEo4veAhejuGHG79SegoZEt-7wYuFkorivUS0AmaJZM-H0tXtku5zvWwmhYTq2GBqH7eTJjLAuuwfIZb_uap_tlt2q3Heap339Hdxk-EsbixAunfDwOiB2izJjEj4bygmbLvd6Le7Ld1nvFSVVNzuwOek2xGFVF_z_6BkJXz1dVL3KVC6BTEmkPeuL6zxYHxbSy4WLOfeGrzT2mBF3y1dgge1YUBmknoXFgpVGwV0xt4vrP8GxJ_Ti1aj-79HAdAH3w0oAXPtXlLEt3ndE3ED30tS3bEq88yMBp63z-TlTdzD2vZqEyjpMifXdYaqI9pGaqwUkDksLfsZ31scp96-WNapxT2iC8tp1eLe2IX15fPmX01tizH9dWH1WzUoLjhzGdLYtd-d1m-WFFbsSVbMqmb3nd-wPaD1sDYrqS1QA6uEltNBZKf_YdTewWojWMoKNWdnKFHG0rpbWnkQqq-E0o2CD1Rb1Wu_wyZGymQ1Lb2cqlyHYnuMtrOUBfHytluPt2pc0BspnKMU7aMUnaMU3aMUvaMUyYtWqg-y8UjsC5rcdrdhyIW0oChajqbfxo-qwavaD2D5VzyAcEg3c5vZAD2JZW8h9jHItYCAaw2m6zDEtVX71uoWmPOacrmPdwrgVcZitU_Q0pq8kdX-1J1TGJVQP-bhVMDjsEK9ChTqVaDQSTwOKWQX2VyHdme7Aos4VWlTZL_dU8gsZSl7HHC2XmkJnMIcSk_Zrsr-3Qo2g12Be9gVyNEpuBOqCjFOWY_sVGDA4mdGZSG2XVZ_p6QLFxPAW1u6wVRmD-rcogyHw47dLc2hV9Wy2lXFmOJbs7wdO6XXslvNpiqi_GAZcSoriITtCgJKu6RTdkri7Wrsf_JJWXjTdgojTsmiSlq1WzZWV7QsnaqCS2V59cklVAHcGC_jndKhyalmDSo7Kaoo-Dqn6VTU-OXP-IqSjW5pQcofcb2iwaBs8Pg4oe75JO-gqO6tegVF-DM2__BCCXaCGHanb326XG9eccGr-qkQnBI_bg9_fBfFjUIplk_CC7fvrtgt-Em38lZJD9DTPUDseL8tIMGwHCTcG7aC5C3zmo3Drmr8YSfPo0gkoimnMe323U2XLgT3aBDLRVGT-O9-kzdk-uk_6zhEn_4T3gTUPQ5J3oNJIO0j0yQultA7jpE-ZHPGn2fqddqJJOq91f0XfgyzxG_sC85VdzBthmzg5hY4AfT62YDdDnhqouS-It51l839v3z_P3aSJA4=
Screenshots
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den Berechnungscode für den Berechnungsmodus Exerted/Boosted, Impale-Schaden und Full DPS zu lokalisieren. Lade den bereitgestellten Build-Code und vergleiche Average mit Max Hit; abgeschlossen ist es, wenn Max Hit den Angriffsgeschwindigkeitsmultiplikator für Full Impale DPS beibehält und dabei den korrekten Combined Total Damage bewahrt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100