PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Shock Nova
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
maximum shock effect should be 85% for shock nova due to the inherent +10% to maximum effect of shock
What is the value from the calculation in Path of Building?
The PoB value does not take this modifier into account when calculating maximum shock effect for shock nova.
How to reproduce the issue
Select shock nova as skill in calcs tab
Hover over the maximum shock effect line
Character build code
https://pobb.in/oj7-uo14zEFf
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Calcs tab with Shock Nova selected, then inspect the calculation behind the maximum shock effect line and compare it with the linked build code. Done means the displayed maximum shock effect accounts for Shock Nova's inherent modifier and matches the in-game value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100