PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

UI for anointing all Blight uniques showing wrong damage change values

Abierto
#6,863 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: behaviour
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

This issue is not affected by in-game behavior. It is just an issue with pob calculations.

What is the behaviour in Path of Building?

When adding "Disciple of the Slaughter" as an anoint on the helmet, the wrong percentage is displayed in anointment selection screen, but the correct percentage is displayed on the main item editor screen.

The same issue occurs with all other anointable blight uniques (all 3 cowls, breathstealer, the stampede, replica stampede, and sporeguard)

How to reproduce the issue
  1. Double click "Cowl of the Thermophile" to edit it
  2. Click Anoint 2...
  3. Change the sort method to "Sort by Average Hit"
  4. Disciple of the Slaughter will be at the top of the list. The display will show an incorrect Average Hit change of +2.4%. (The other three displayed values are also incorrect)
  5. Click "Anoint Disciple of the Slaughter"
  6. the display now shows the correct Average Hit change of +7.2% (the other three displayed values are now correct as well)
Character build code
https://pobb.in/MYa_ioF2EULL
Screenshots

Path_of_Building_E2grXxC1NH

Path_of_Building_fq1jWpHRB7

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en la pantalla de selección de anointment de Cowl of the Thermophile y reproduce los valores incorrectos ordenando por Average Hit. Compara los cambios mostrados antes y después de aplicar Disciple of the Slaughter; se considera terminado cuando la pantalla de selección coincide con los valores correctos mostrados en el main item editor para todos los Blight uniques que admiten anointment.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop, frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.