PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

UI for anointing all Blight uniques showing wrong damage change values

Open
#6,863 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: behaviour
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

This issue is not affected by in-game behavior. It is just an issue with pob calculations.

What is the behaviour in Path of Building?

When adding "Disciple of the Slaughter" as an anoint on the helmet, the wrong percentage is displayed in anointment selection screen, but the correct percentage is displayed on the main item editor screen.

The same issue occurs with all other anointable blight uniques (all 3 cowls, breathstealer, the stampede, replica stampede, and sporeguard)

How to reproduce the issue
  1. Double click "Cowl of the Thermophile" to edit it
  2. Click Anoint 2...
  3. Change the sort method to "Sort by Average Hit"
  4. Disciple of the Slaughter will be at the top of the list. The display will show an incorrect Average Hit change of +2.4%. (The other three displayed values are also incorrect)
  5. Click "Anoint Disciple of the Slaughter"
  6. the display now shows the correct Average Hit change of +7.2% (the other three displayed values are now correct as well)
Character build code
https://pobb.in/MYa_ioF2EULL
Screenshots

Path_of_Building_E2grXxC1NH

Path_of_Building_fq1jWpHRB7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the anointment selection screen for Cowl of the Thermophile and reproduce the incorrect values by sorting by Average Hit. Compare the displayed changes before and after applying Disciple of the Slaughter; done when the selection screen matches the correct values shown in the main item editor for all anointable Blight uniques.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.