PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Attacks per second calculation (on poet's pen wand) possible rounding error

Abierto
#6,839 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: calculation
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

The trade site calculates "attacks per second" to 1.72 See here:
image

What is the value from the calculation in Path of Building?

If you import/copy item into pob it auto calculates it to be 1.73:
image

I am guessing this is a rounding error.

How to reproduce the issue
  1. Go to trade:

https://www.pathofexile.com/trade/search/Standard/kX7n23Qi5

  1. Copy item:
Item Class: Wands
Rarity: Unique
The Poet's Pen
Carved Wand
--------
Wand
Quality: +30% (augmented)
Physical Damage: 9-17
Critical Strike Chance: 7.00%
Attacks per Second: 1.72 (augmented)
--------
Requirements:
Level: 12
Int: 47
--------
Sockets: B-B-R 
--------
Item Level: 84
--------
Quality does not increase Physical Damage (enchant)
1% increased Attack Speed per 8% Quality (enchant)
--------
15% increased Spell Damage (implicit)
--------
+1 to Level of Socketed Skill Gems per 25 Player Levels
Trigger a Socketed Spell when you Attack with this Weapon, with a 0.25 second Cooldown
Adds 3 to 5 Physical Damage to Attacks with this Weapon per 3 Player Levels
12% increased Attack Speed
--------
In every piece of prose, lies a tiny spark of magic.
--------
Note: ~price 3 exalted
  1. See that pob thinks that 1.72 should be 1.73
Character build code
No need you can do this with any character as its just the copy/paste of the item.
Screenshots

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce la discrepancia importando el objeto Poet's Pen proporcionado y comparando la velocidad de ataque de Path of Building con el anuncio de intercambio. Sigue el cálculo de la velocidad de ataque desde el punto de entrada de la importación del objeto o del cálculo y, a continuación, verifica que el valor mostrado coincida con el valor esperado de 1.72 sin afectar a otros cálculos de velocidad de ataque.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.